-
Notifications
You must be signed in to change notification settings - Fork 140
Implement WAFPolicy controller #3532
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was
linked to
issues
Jun 21, 2025
e3a3e51 to
89122cd
Compare
6 tasks
89122cd to
469bfd8
Compare
tataruty
reviewed
Jun 24, 2025
469bfd8 to
77a793f
Compare
ddeaa8e to
499cfed
Compare
tataruty
reviewed
Jun 25, 2025
499cfed to
752013c
Compare
ad59974 to
047418f
Compare
047418f to
28bcbe2
Compare
sjberman
reviewed
Jul 4, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a couple small things, but overall looks pretty good!
internal/controller/nginx/config/policies/waf/generator_test.go
Outdated
Show resolved
Hide resolved
sjberman
reviewed
Jul 7, 2025
sjberman
approved these changes
Jul 8, 2025
salonichf5
approved these changes
Jul 8, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
ciarams87
added a commit
that referenced
this pull request
Jul 9, 2025
As a user of NGF I want my WafPolicy configuration applied to NGINX for the Gateway or Route scope So that I can enable WAF protection on my traffic Solution: Implement the WAFPolicy controller.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Problem:
As a user of NGF
I want my WafPolicy configuration applied to NGINX for the Gateway or Route scope
So that I can enable WAF protection on my traffic
Solution: Implement the WAFPolicy controller.
Testing: Over 90% unit test coverage, and manual testing in a GKE cluster
Closes: #3454
Checklist
Before creating a PR, run through this checklist and mark each as complete.
Release notes
If this PR introduces a change that affects users and needs to be mentioned in the release notes,
please add a brief note that summarizes the change.